Merged
Conversation
Contributor
|
JSDelivr CDN can support different kinds of links.
People should probably be using the |
Contributor
Author
|
And a specific version via github |
Contributor
Author
|
Ping @tyrasd |
tyrasd
approved these changes
Nov 13, 2023
Contributor
Author
|
Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a little lost, but I think I've found the right place.
This all started with a 404. Specifically id-tagging-schema references
https://cdn.jsdelivr.net/gh/mapbox/maki/icons/toll-15.svg. Interestinglyhttps://cdn.jsdelivr.net/gh/mapbox/maki/icons/toll.svgworks. I checked a few other maki urls and the seem to work with both url formats, the images look the same to me, but aren't byte for byte the same.eg
https://cdn.jsdelivr.net/gh/mapbox/maki/icons/shop-15.svgvshttps://cdn.jsdelivr.net/gh/mapbox/maki/icons/shop.svg.I've found my maki-toll, but no
15. Time to head up a level, and here we are.But why are most of the
15s working?It seems maki deprecated the
15and11sizes in v7. The new icons only work onhttps://cdn.jsdelivr.net/gh/mapbox/maki/icons/animal-shelter.svg, nothttps://cdn.jsdelivr.net/gh/mapbox/maki/icons/animal-shelter-15.svg. My guess is the CDN still has old files on the old urls, with new files on the new urls.So no icons from here will have any changes since pre v7, and new icons 404.